-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mk_core: fix timeout given to EVFILT_TIMER in some BSD #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fix timeout parameter given to EV_SET(EVFILT_TIMER) in BSD system other than FreeBSD. Only FreeBSD(or LINUX_SECOND) has NOTE_SECONDS defined and specify seconds in EV_SET(EVFILT_TIMER). Other BSD expects milliseconds. Tested in NetBSD environment. Signed-off-by: enukane <[email protected]>
edsiper
added a commit
that referenced
this pull request
Jun 4, 2015
mk_core: fix timeout given to EVFILT_TIMER in some BSD
thanks |
Closed
fujimotos
pushed a commit
to fujimotos/fluent-bit
that referenced
this pull request
Jul 22, 2019
output: new FlowCounter output documentation
4 tasks
nathalapooja
pushed a commit
to amazon-contributing/upstream-to-fluent-bit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed timeout parameter given to EV_SET(EVFILT_TIMER) in some BSD.
Only FreeBSD (or LINUX_SECOND?) has NOTE_SECONDS defined and specify seconds
in EV_SET(EVFILT_TIMER). Other BSD (NetBSD, OpenBSD, DragonFlyBSD) requires milliseconds.
This caused 1000 times faster timeout & flushing.
I've tested this patch in NetBSD environment (on my netbsd-work branch).